Skip to content

fix: narrower typing for varification check instance status #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: narrower typing for varification check instance status #1114

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f682cb1
Create stale.yml
tiwarishubham635 Aug 8, 2025
54434d8
Rename stale.yml to close-stale-issues.yml
tiwarishubham635 Aug 8, 2025
c3f328b
narrower typing for varification check instance status
T0nd0Tara Aug 8, 2025
e7dfcc7
narrower typing for varification check resource status
T0nd0Tara Aug 8, 2025
1a5bd97
Merge branch 'main' into narrower-typing-for-VerificationCheckInstanc…
T0nd0Tara Aug 9, 2025
4e6b64d
fix conflicts
T0nd0Tara Aug 9, 2025
5800b2c
fix conflicts 2
T0nd0Tara Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/rest/verify/v2/service/verificationCheck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,15 @@ export function VerificationCheckListInstance(
return instance;
}

interface VerificationCheckPayload extends VerificationCheckResource {}
interface VerificationCheckPayload extends VerificationCheckResource { }

interface VerificationCheckResource {
sid: string;
service_sid: string;
account_sid: string;
to: string;
channel: VerificationCheckChannel;
status: string;
status: 'pending' | 'approved' | 'canceled' | 'max_attempts_reached' | 'deleted' | 'failed' | 'expired';
valid: boolean;
amount: string;
payee: string;
Expand Down Expand Up @@ -222,7 +222,7 @@ export class VerificationCheckInstance {
/**
* The status of the verification. Can be: `pending`, `approved`, `canceled`, `max_attempts_reached`, `deleted`, `failed` or `expired`.
*/
status: string;
status: VerificationCheckResource['status'];
/**
* Use \"status\" instead. Legacy property indicating whether the verification was successful.
*/
Expand Down