Skip to content

Get CI passing #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Get CI passing #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"ember-cli-addon-docs": "ember-learn/ember-cli-addon-docs#4f5bfd11",
"ember-cli-addon-docs-esdoc": "0.2.3",
"ember-cli-app-version": "3.2.0",
"ember-cli-babel": "7.18.0",
"ember-cli-babel": "7.21.0",
"ember-cli-blueprint-test-helpers": "0.19.2",
"ember-cli-dependency-checker": "3.2.0",
"ember-cli-deploy": "1.0.2",
Expand All @@ -110,7 +110,7 @@
"ember-maybe-import-regenerator": "0.1.6",
"ember-qunit": "4.6.0",
"ember-resolver": "7.0.0",
"ember-source": "3.17.0",
"ember-source": "3.17.3",
"ember-try": "1.4.0",
"eslint": "6.8.0",
"eslint-config-prettier": "6.10.0",
Expand Down
4 changes: 2 additions & 2 deletions ts/tests/commands/precompile-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe('Acceptance: ts:precompile command', function() {

it('emits errors to the console when precompilation fails', async () => {
fs.ensureDirSync('app');
fs.writeFileSync('app/test-file.ts', `export const testString: string = 123;`);
fs.writeFileSync('app/test-file.ts', `export const testString: string = {};`);

let output = '';
let unhookStdout = hook(process.stdout, { quiet: true }, chunk => (output += chunk));
Expand All @@ -49,7 +49,7 @@ describe('Acceptance: ts:precompile command', function() {
await ember(['ts:precompile']);
expect.fail('Precompilation should have failed');
} catch {
expect(output).to.include(`Type '123' is not assignable to type 'string'.`);
expect(output).to.include(`Type '{}' is not assignable to type 'string'.`);
} finally {
unhookStdout();
unhookStderr();
Expand Down
Loading