Issue 355 #376
Merged
Issue 355 #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kszmigiel
commented
Jun 1, 2020
kszmigiel
commented
- Closes Using TypedDict for templates rendering #355
stub for _build_app_dict (#351)
sobolevn
requested changes
Jun 1, 2020
There was a problem hiding this comment.
Thanks a lot!
Let's also test that it works, because we already have a problematic use-case.
You will need to write something similar: https://github.com/typeddjango/django-stubs/blob/master/test-data/typecheck/test_request.yml
django-stubs/shortcuts.pyi
Outdated
| @@ -13,15 +13,15 @@ from django.template.context import Context | |||
|
|
|||
| def render_to_response( | |||
| template_name: Union[str, Sequence[str]], | |||
| context: Optional[Union[Context, Dict[str, Any]]] = ..., | |||
| context: Optional[Union[Context, Mapping]] = ..., | |||
There was a problem hiding this comment.
Mapping is generic. So, I guess it has to be Mapping[str, Any]
Revert "Allow template render to string helper functions to accept Co…
sobolevn
approved these changes
Jun 1, 2020
|
Thanks a lot! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.