Add missing re-imports to django.db.models. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurnikov
requested changes
Jan 30, 2019
| @@ -46,7 +55,12 @@ from .deletion import ( | |||
| PROTECT as PROTECT, | |||
| ) | |||
|
|
|||
| from .query import QuerySet as QuerySet, RawQuerySet as RawQuerySet | |||
| from .query import ( | |||
| Prefetch as Prefetch, | |||
There was a problem hiding this comment.
Both Prefetch and prefetch_related_objects are not yet defined in query.py. Please either add them there, or remove them from here, so that test suite would pass.
|
There is a related django tests folder |
|
I've updated PR, 2 ignored test errors are caused by the fact that Prefetch can add new attributes to model, not sure if there is more clean solution for this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.