Skip to content

make FormMixin generic to allow proper typing for LoginView #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Oct 31, 2020
Merged

make FormMixin generic to allow proper typing for LoginView #515

merged 1 commit into from Oct 31, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2020

i have made things!

related issues

closes #514

tests look good, i added a new one, let me know if you want any additional tests

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks!

Let's ask someone else for a quick look, maybe we are missing something!
And then merge it 🛷

@sobolevn sobolevn merged commit f08b428 into typeddjango:master Oct 31, 2020
@sobolevn
Copy link
Member

🎉

@ghost
Copy link
Author

ghost commented Oct 31, 2020

awesome, thanks!

@ghost ghost deleted the issue-514 branch November 1, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

LoginView has a typing issue
2 participants