52/model subtypes dont typecheck #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rather annoying errors that I had to add ignores for: I'll keep on adding ignores for now... |
mkurnikov
reviewed
Mar 25, 2019
syastrov
force-pushed
the
52/model_subtypes_dont_typecheck
branch
from
59aa6e4 to
1d737a0
Compare
…h other due to fallback_to_any = True. Fixes typeddjango#52. - Added a stub for __getstate__ to Model. - Added a stub for clean() to Model. - Correct arg type for sort_dependencies so they are covariant (Iterable rather than List). Test ignores: - Added some test ignores in cases where a model inherits from 2 different base models. - Added some test ignores for cases that MyPy flags as errors due to variable redefinitions or imports that are incompatible types.
syastrov
force-pushed
the
52/model_subtypes_dont_typecheck
branch
from
1d737a0 to
70a92fd
Compare
mkurnikov
reviewed
Mar 28, 2019
| class Child1(Parent1, Parent2): | ||
|
|
||
| # TODO: Remove the 2 expected errors on the next line once mypy issue https://github.com/python/mypy/issues/2619 is resolved: | ||
| class Child1(Parent1, Parent2): # E: Definition of "objects" in base class "Parent1" is incompatible with definition in base class "Parent2" # E: Definition of "_default_manager" in base class "Parent1" is incompatible with definition in base class "Parent2" |
There was a problem hiding this comment.
Could you change it into multiline error? This is the example how it supported in the test plugin
https://github.com/mkurnikov/pytest-mypy-plugins/blob/master/pytest_mypy/tests/e2e/output.test#L41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.