Skip to content

feat: change binary from "base/version/mongod" to "base/mongod-arch-dist-version" #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2021
Merged

feat: change binary from "base/version/mongod" to "base/mongod-arch-dist-version" #454

merged 2 commits into from
Mar 10, 2021

Conversation

hasezoey
Copy link
Member

@hasezoey hasezoey commented Mar 3, 2021

@hasezoey hasezoey added this to the 7.0 milestone Mar 3, 2021
@hasezoey hasezoey requested a review from nodkz March 3, 2021 13:10
@codecov
Copy link

codecov bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #454 (06cfccb) into beta (d16e802) will decrease coverage by 0.04%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #454      +/-   ##
==========================================
- Coverage   81.61%   81.57%   -0.05%     
==========================================
  Files          12       12              
  Lines        1485     1487       +2     
  Branches      353      353              
==========================================
+ Hits         1212     1213       +1     
  Misses        269      269              
- Partials        4        5       +1
Impacted Files Coverage Δ
...memory-server-core/src/util/MongoBinaryDownload.ts 36.31% <0.00%> (-0.19%) ⬇️
...godb-memory-server-core/src/util/DryMongoBinary.ts 99.09% <100.00%> (-0.91%) ⬇️
...mongodb-memory-server-core/src/util/getos/index.ts 70.45% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d16e802...06cfccb. Read the comment docs.

@hasezoey hasezoey linked an issue Mar 5, 2021 that may be closed by this pull request
Add distro and version to the mongod file #256
Closed
@hasezoey
Copy link
Member Author

@nodkz is this ok to be changed, or should it stay like it was?

@nodkz
Copy link
Collaborator

nodkz commented Mar 10, 2021

More details is good.
Moreover if somebody uses heterogeneous systems it helps avoid unproper binary using.

@hasezoey hasezoey merged commit 06cfccb into typegoose:beta Mar 10, 2021
@hasezoey hasezoey deleted the changeBinaryName branch March 10, 2021 09:30
@github-actions
Copy link

🎉 This PR is included in version 7.0.0-beta.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Pull Request released | Issue is fixed label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodkz nodkz Awaiting requested review from nodkz nodkz is a code owner

Assignees
No one assigned
Labels
enhancement released on @beta released Pull Request released | Issue is fixed
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

Add distro and version to the mongod file
2 participants
@hasezoey @nodkz