Skip to content

Missing converter: no-shadowed-variable #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Oct 2, 2019 · 2 comments · Fixed by #218
Closed

Missing converter: no-shadowed-variable #174

JoshuaKGoldberg opened this issue Oct 2, 2019 · 2 comments · Fixed by #218
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@JoshuaKGoldberg
Copy link
Member

💥 Missing Converter

  • tslint-to-eslint-config version: 1.2.0
  • typescript-eslint version: 2.3.2

TSLint Rule Name

no-shadowed-variable
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments hacktoberfest labels Oct 2, 2019
@JoshuaKGoldberg
Copy link
Member Author

The issue here is that this package doesn't know how to convert the TSLint rule into the equivalent ESLint rule. Accepting PRs to add in a converter! 🙌

docs/Development.md has a root overview for how to get started. Within that, docs/Architecture.md#rule-converters talks about how these converters operate. Check the typescript-eslint roadmap to see suggestions on equivalent ESLint rules to convert to.

See #189 for an example of a simple rule converter that was recently added in.

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send in a PR to resolve this! ✨ label Oct 2, 2019
@alejo90
Copy link
Contributor

alejo90 commented Oct 5, 2019

@JoshuaKGoldberg I'm taking this one

@alejo90 alejo90 mentioned this issue Oct 6, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fixes #174] implement no-shadowed-variable converter alejo90/tslint-to-eslint-config
2 participants
@alejo90 @JoshuaKGoldberg