Skip to content

Convert space-within-parens to space-in-parens #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cheeZery opened this issue Dec 30, 2019 · 0 comments · Fixed by #314
Closed

Convert space-within-parens to space-in-parens #307

cheeZery opened this issue Dec 30, 2019 · 0 comments · Fixed by #314
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨

Comments

@cheeZery
Copy link

🐛 Bug Report

  • tslint-to-eslint-config version: 0.5.0
  • ESLint version: 6.8.0
  • Node version: 11.10.0

Actual Behavior

TSLint rule space-within-parens will be converted to @typescript-eslint/space-within-parens (see #184 and #193), but there is no rule for that (anymore?) in the @typescript-eslint plugin. Instead ESLint's core rule space-in-parens should be used, as stated here as well.

Expected Behavior

TSLint rule space-within-parens will be converted to space-in-parens.
@cheeZery cheeZery changed the title Convert space-within-parens Convert space-within-parens to space-in-parens Dec 30, 2019
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments and removed type: bug Something isn't working labels Dec 31, 2019
@adamazing adamazing mentioned this issue Jan 13, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: incorrect converter Rule converter with incomplete, incorrect, or invalid rule names and/or arguments good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert space-within-parens to space-in-parens
2 participants
@JoshuaKGoldberg @cheeZery