Skip to content

Convert space-within-parens to space-in-parens #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

Convert space-within-parens to space-in-parens #314

merged 1 commit into from
Jan 15, 2020

Conversation

adamazing
Copy link
Contributor

@adamazing adamazing commented Jan 13, 2020 •
edited
Loading

PR Checklist

Overview

TSLint rule space-within-parens will be converted to space-in-parens instead of @typescript-eslint/space-within-parens

@adamazing
Copy link
Contributor Author

Is anything else required?

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - rule options still match up to https://eslint.org/docs/rules/space-in-parens. Thanks @adamazing!

@JoshuaKGoldberg
Copy link
Member

Nothing else needed 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4507cbf into typescript-eslint:master Jan 15, 2020
@adamazing adamazing deleted the convert-space-within-parens-to-space-in-parens branch January 16, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert space-within-parens to space-in-parens
2 participants
@adamazing @JoshuaKGoldberg