-
Notifications
You must be signed in to change notification settings - Fork 100
Closed
Labels
area: command lineArguments parsing and/or output printing on the CLI.Arguments parsing and/or output printing on the CLI.area: editor configsRelated to outputting IDE settings filesRelated to outputting IDE settings filesstatus: accepting prsPlease, send in a PR to resolve this! ✨Please, send in a PR to resolve this! ✨type: enhancementNew feature or requestNew feature or request
Milestone
Description
🚀 Feature Request
Forking from #742: should editor config conversions not be applied if --editor
isn't specified?
Existing Behavior
If a .vscode/settings.json
exists, tslint-to-eslint-config
will run on it.
Change Proposal
This can be surprising to users: they may not want to convert their editor config, and prior to #742 and #744 being resolved, this can be a destructive operation. Should we make conversion...
- ...opt-in until those two issues are resolved?
- ...opt-in even after those two issues are resolved?
Personally, I'm in favor of keeping the existing behavior because both those issues are pretty straightforward to resolve: there are already packages for JSON5 and JSON diff patching. But we should discuss a bit instead of letting me steamroll 😄. What do you think, @KingDarBoja and @SgtPooki?
Metadata
Metadata
Assignees
Labels
area: command lineArguments parsing and/or output printing on the CLI.Arguments parsing and/or output printing on the CLI.area: editor configsRelated to outputting IDE settings filesRelated to outputting IDE settings filesstatus: accepting prsPlease, send in a PR to resolve this! ✨Please, send in a PR to resolve this! ✨type: enhancementNew feature or requestNew feature or request