-
Notifications
You must be signed in to change notification settings - Fork 100
Add missing converter: no-null-keyword #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing converter: no-null-keyword #202
Conversation
Add converter for typescript-eslint#173
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking mostly great - just one addition please!
I can't run the end-to-end tests. I have node 12.11.1 and tslint installed. It seems that the Do you have an Idea what could be the issue? Since it works in circleci... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks!
I'll take a look at the test shenanigans... |
Ignoring end-to-end test failures as they're removed in master. 🤷♂ |
Add converter for #173
PR Checklist
status: accepting prs
Overview
Add converter to convert
no-null-keyword
rule. Will add plugin eslint-plugin-no-null to settings.