Skip to content

Add missing converter: no-null-keyword #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

da-snap
Copy link
Contributor

@da-snap da-snap commented Oct 4, 2019

Add converter for #173

PR Checklist

Overview

Add converter to convert no-null-keyword rule. Will add plugin eslint-plugin-no-null to settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly great - just one addition please!

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 4, 2019
@da-snap
Copy link
Contributor Author

da-snap commented Oct 5, 2019

I can't run the end-to-end tests. I have node 12.11.1 and tslint installed. It seems that the testArgs.join(" ") does not work for me.
When I try to log what is passed to exec I get something like this:
node [...]/tslint-to-eslint-config/bin/tslint-to-eslint-config " - - c o n f i g " "[...]/t s l i n t - t o - e s l i n t - c o n f i g / t e s t / t e s t s / s t a n d a l o n e t s l i n t . j s o n / . e s l i n t r c . j s o n " " - - t s l i n t " " [...] / t s l i n t - t o - e s l i n t - c o n f i g / t e s t / t e s t s / s t a n d a l o n e t s l i n t . j s o n / t s l i n t . j s o n "

Do you have an Idea what could be the issue? Since it works in circleci...

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@JoshuaKGoldberg
Copy link
Member

I'll take a look at the test shenanigans...

@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Oct 6, 2019
@JoshuaKGoldberg
Copy link
Member

Ignoring end-to-end test failures as they're removed in master. 🤷‍♂

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6a59ffa into typescript-eslint:master Oct 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing converter: no-null-keyword
2 participants