Added the file extension for a VS Code workspace file to .gitignore. … #212
Conversation
…Created a test for use-default-type-parameter, add the rule to rules/converters.ts, and created it it's own converter file.
| @@ -9,3 +9,5 @@ test/*.js | |||
| ~test/jest.config.js | |||
| !test/tests/**/.eslintrc* | |||
| !test/tests/**/*.log | |||
| #VS Code workspace file | |||
| *.code-workspace | |||
There was a problem hiding this comment.
Err this and the PR title look unrelated. Could you please file a separate issue if you'd like this change?
There was a problem hiding this comment.
My apologies for the delay... I went out of town and had no service so was pretty disconnected, glad to see it got taken care of. Well, if you would like to have code-workspaces ignored I'm not opposed to resbubmitting.
| return { | ||
| rules: [ | ||
| { | ||
| ruleName: "@typescript-eslint/use-default-type-parameter", |
There was a problem hiding this comment.
|
Just a heads up @tonythetiger323, #221 was already merged in (the author had asked early on about this rule). Are you still interested in the .gitignore changes? |
JoshuaKGoldberg
added
status: waiting for reviewer
|
@tonythetiger323 if you merge from master, the CI failures for the |
|
Closing to keep the list of open PRs nice and tidy. Please do resubmit if you're still interested in sending this contribution in! 💖 |
…Created a test for use-default-type-parameter, add the rule to rules/converters.ts, and created it it's own converter file.
PR Checklist
status: accepting prsOverview
It was pretty straightforward as its one of the few rule tslint rules that doesn't have an eslint equivalent which ban-ts-ignore is pretty much the same so I just followed the way it was laid out to a t. Um, tangent, there appears to be something wrong with your e2e and I briefly looked at it but don't have much e2e testing experience. I can create and issue if you'd like.