Skip to content

added semicolon rule converter plus tests #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2019
Merged

added semicolon rule converter plus tests #220

merged 5 commits into from
Oct 6, 2019

Conversation

YashdalfTheGray
Copy link
Contributor

@YashdalfTheGray YashdalfTheGray commented Oct 6, 2019 •
edited
Loading

PR Checklist

Overview

Issue related changes

  • added a rule converter for semicolon in the TSLint ruleset
  • added proper handling for the options that come with the rule itself
  • added tests to make sure that the right comparative rules are being output
  • added a couple of notices so that the user is informed of things not automatically converted

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 6, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an amusingly convoluted set of rule options... thanks for diving into this @YashdalfTheGray! Just a few change requests.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 6, 2019
@YashdalfTheGray
Copy link
Contributor Author

@JoshuaKGoldberg I cut another PR #224 for the .vscode change and updated this PR with the other requested changes.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 6, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks @YashdalfTheGray! ✨

@JoshuaKGoldberg JoshuaKGoldberg merged commit c3fb72e into typescript-eslint:master Oct 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: semicolon
2 participants
@YashdalfTheGray @JoshuaKGoldberg