Skip to content

Corrected 'tslint-eslint-plugin' to be 'eslint-plugin-tslint' #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Corrected 'tslint-eslint-plugin' to be 'eslint-plugin-tslint' #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123838b
Corrected 'tslint-eslint-plugin' to be 'eslint-plugin-tslint'
JoshuaKGoldberg Apr 26, 2020
fe1140c
Corrected reporting test output's order
JoshuaKGoldberg Apr 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/reporting/reportConversionResults.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ describe("reportConversionResults", () => {
` Check ${logger.debugFileName} for details.`,
``,
`⚡ 5 packages are required for this ESLint configuration. ⚡`,
` yarn add @typescript-eslint/eslint-plugin @typescript-eslint/parser @typescript-eslint/tslint-eslint-plugin eslint eslint-config-prettier --dev`,
` yarn add @typescript-eslint/eslint-plugin @typescript-eslint/eslint-plugin-tslint @typescript-eslint/parser eslint eslint-config-prettier --dev`,
);
expectEqualWrites(
logger.info.write,
Expand Down Expand Up @@ -276,7 +276,7 @@ describe("reportConversionResults", () => {
` Check ${logger.debugFileName} for details.`,
``,
`⚡ 5 packages are required for this ESLint configuration. ⚡`,
` yarn add @typescript-eslint/eslint-plugin @typescript-eslint/parser @typescript-eslint/tslint-eslint-plugin eslint eslint-config-prettier --dev`,
` yarn add @typescript-eslint/eslint-plugin @typescript-eslint/eslint-plugin-tslint @typescript-eslint/parser eslint eslint-config-prettier --dev`,
);
expectEqualWrites(
logger.info.write,
Expand Down
2 changes: 1 addition & 1 deletion src/reporting/reportOutputs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const logMissingPackages = (
const packageNames = uniqueFromSources([
"@typescript-eslint/eslint-plugin",
"@typescript-eslint/parser",
ruleConversionResults.missing.length !== 0 && "@typescript-eslint/tslint-eslint-plugin",
ruleConversionResults.missing.length !== 0 && "@typescript-eslint/eslint-plugin-tslint",
"eslint",
...Array.from(
ruleConversionResults.extends?.map((extension) => extension.split("/")[0]) ?? [],
Expand Down