Skip to content

Update typescript-eslint monorepo to v3 (major) #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2020
Merged

Update typescript-eslint monorepo to v3 (major) #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e6b9be
Update typescript-eslint monorepo to v3
renovate-bot May 21, 2020
6ce2c8b
Applied suggestion for DeepPartial
JoshuaKGoldberg May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
"@types/glob": "7.1.1",
"@types/jest": "25.2.3",
"@types/node": "12.12.21",
"@typescript-eslint/eslint-plugin": "2.34.0",
"@typescript-eslint/parser": "2.34.0",
"@typescript-eslint/eslint-plugin": "3.0.0",
"@typescript-eslint/parser": "3.0.0",
"babel-jest": "26.0.1",
"eslint": "7.0.0",
"husky": "4.2.5",
Expand Down
2 changes: 1 addition & 1 deletion src/input/findReportedConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Exec } from "../adapters/exec";

export type DeepPartial<T> = {
[P in keyof T]: T[P] extends {} ? DeepPartial<T[P]> : T[P];
[P in keyof T]?: T[P] extends Record<P, T[P]> ? DeepPartial<T[P]> : T[P];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @bbarry! Seems to work great.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading it more this type is wrong? I think it should work for now because it is basically being treated as any here but I'll try and write some tests and put in a pr at some point.

};

export type FindReportedConfigurationDependencies = {
Expand Down