Factored config rule conversions into comment conversions #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
the
status: waiting for reviewer
2 tasks
|
Resolved the merge conflicts, tested locally and everything seems okay 🍰 |
KingDarBoja
approved these changes
Sep 19, 2020
|
Oh very nice, thanks @KingDarBoja! I'm excited to get this out the door 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Adds a
ruleEquivalentsmember to the rule conversion results, which is then passed to the comment conversions.It's possible that a file might have a comment not previously converted, so the comment logic still receives the
convertersused to calculate rule equivalents from scratch.