Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/converters/lintConfigs/rules/ruleConverters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ import { convertJsxWrapMultiline } from "./ruleConverters/eslint-plugin-react/js
import { convertNoAsyncSubscribe } from "./ruleConverters/eslint-plugin-rxjs/no-async-subscribe";
import { convertNoIgnoredReplayBuffer } from "./ruleConverters/eslint-plugin-rxjs/no-ignored-replay-buffer";
import { convertNoRedundantNotify } from "./ruleConverters/eslint-plugin-rxjs/no-redundant-notify";
import { convertNoShareReplay } from "./ruleConverters/eslint-plugin-rxjs/no-sharereplay";
import { convertNoUnsafeSubjectNext } from "./ruleConverters/eslint-plugin-rxjs/no-unsafe-subject-next";

/**
Expand Down Expand Up @@ -377,6 +378,7 @@ export const ruleConverters = new Map([
["rxjs-no-async-subscribe", convertNoAsyncSubscribe],
["rxjs-no-ignored-replay-buffer", convertNoIgnoredReplayBuffer],
["rxjs-no-redundant-notify", convertNoRedundantNotify],
["rxjs-no-sharereplay", convertNoShareReplay],
["rxjs-no-unsafe-subject-next", convertNoUnsafeSubjectNext],

// These converters are all for rules that need more complex option conversions.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoShareReplay: RuleConverter = (tslintRule) => {
return {
rules: [
{
...(tslintRule.ruleArguments.length !== 0 && {
ruleArguments: tslintRule.ruleArguments,
}),
ruleName: "rxjs/no-sharereplay",
},
],
plugins: ["eslint-plugin-rxjs"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import { convertNoShareReplay } from "../no-sharereplay";

describe(convertNoShareReplay, () => {
test("conversion without arguments", () => {
const result = convertNoShareReplay({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "rxjs/no-sharereplay",
},
],
plugins: ["eslint-plugin-rxjs"],
});
});

test("conversion without arguments", () => {
const result = convertNoShareReplay({
ruleArguments: [
{
allowConfig: true,
},
],
});

expect(result).toEqual({
rules: [
{
ruleName: "rxjs/no-sharereplay",
ruleArguments: [
{
allowConfig: true,
},
],
},
],
plugins: ["eslint-plugin-rxjs"],
});
});
});