Skip to content

typescript in 5 minutes 이미지 파일 추가, release note 3.9 수정 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2020
Merged

typescript in 5 minutes 이미지 파일 추가, release note 3.9 수정 #89

merged 3 commits into from
Jun 9, 2020

Conversation

dvlprsh
Copy link
Member

@dvlprsh dvlprsh commented Jun 8, 2020

  1. [typescript in 5 minutes] 맨 하단 이미지 파일이 assets 폴더에 존재하지 않아서 추가했습니다.
  2. [typescript in 5 minutes] 다운로드 링크가 변경되어서 수정했습니다.
  3. [release notes 3.9] 이전 pr (릴리즈 노트 3.9 문서 업데이트 (resolve #82) #85)에서 달렸던 리뷰가 커밋된줄 알았는데 반영이 안되어 있어서 수정했습니다.

리뷰 부탁드립니다!!

@dvlprsh dvlprsh requested review from bumkeyy, guyeol and yeonjuan June 8, 2020 13:04
bumkeyy
bumkeyy approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@bumkeyy bumkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

yeonjuan
yeonjuan approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 고생하셨습니다!

@yeonjuan yeonjuan merged commit 3b00426 into master Jun 9, 2020
@yeonjuan yeonjuan deleted the fix-dvlprsh branch June 9, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumkeyy bumkeyy bumkeyy approved these changes

@yeonjuan yeonjuan yeonjuan approved these changes

@guyeol guyeol Awaiting requested review from guyeol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvlprsh @bumkeyy @yeonjuan