Skip to content

Conversation

vedraan
Copy link
Contributor

@vedraan vedraan commented Jun 11, 2021

Description

The docs assume that routes will always be in a subfolder of express app which may not be true and in which case the docs could use a touchup.

E.g. in a hexagonal architecture, Express is considered an adapter and api routes are ports so you may need something like:

useExpressServer(this.app, {
  routePrefix: '/api',
  controllers: [path.join(__dirname, '../../ports/api/routes/**/*.*')],
});

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

@vedraan vedraan changed the title Update use of glob patterns in docs docs: Update use of glob patterns in docs in README.md Jun 11, 2021
@jotamorais jotamorais merged commit f4fe9f1 into typestack:develop Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants