Skip to content

fix: Fixed example in README.md #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

ArtemLavrentii
Copy link
Contributor

Most likely the intent of this lambda was to return an object, and not to have a code-block with labels.

Description

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #742

Most likely the intent of this lambda was to return an object, and not to have a code-block with labels.
@ArtemLavrentii
Copy link
Contributor Author

ArtemLavrentii commented Jul 4, 2021

I'm not 100% that even this is a correct example. Shouldn't upload option just be an object ?

Or maybe it should be called here instead ?

saveFile(@UploadedFile("fileName", { options: fileUploadOptions }) file: any) {

@jotamorais jotamorais merged commit cf1117d into typestack:develop Aug 4, 2021
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: Fixed example in README.md
2 participants