Skip to content

MIR: mention check-mir for dependency validation #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

MIR: mention check-mir for dependency validation #74

merged 1 commit into from
Jul 2, 2025
+4 −2

Conversation

TheJJ
Copy link
Contributor

@TheJJ TheJJ commented Jun 26, 2025

it's mentioned in the reviewer template already, but the reporter should also use it.

slyon
slyon reviewed Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (non-blocking): maybe adding it to "TODO-A" as "No further depends or recommends dependencies that are not yet in main (checked with check-mir)" might make it less likely to be missed.

@slyon slyon added the MIR For the attention of the MIR team label Jul 1, 2025
setharnold
setharnold reviewed Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@setharnold setharnold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TheJJ TheJJ force-pushed the check-mir branch 2 times, most recently from 23c0563 to d2ae9d6 Compare July 1, 2025 14:55
@TheJJ
Copy link
Contributor Author

TheJJ commented Jul 1, 2025

added both changes :)

slyon
slyon approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny non-blocking nitpick inline, otherwise LGTM.

@TheJJ
MIR: mention check-mir for dependency validation
Loading
Loading status checks…
7370f7e
@s-makin s-makin merged commit 8a0605f into ubuntu:main Jul 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setharnold setharnold

@slyon slyon

@joalif joalif

@didrocks didrocks

@cpaelzer cpaelzer

Assignees
No one assigned
Labels
MIR For the attention of the MIR team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheJJ @slyon @setharnold @s-makin