-
Notifications
You must be signed in to change notification settings - Fork 6
Update to Go 1.14 and deploy app to Heroku dyno. #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tructure of HandleDeleteProgram. Comment uniformity.
Alright. This PR turned into a lot more than I anticipated. Here's all that I have done:
I will post a review of the code with commentary later today. Things are looking in pretty good shape. Sorry for dumping so much information on you all so suddenly. Hope that you're all in good health and had a good finals week. Here's to the start of spring break! |
Can you do me a quick favour and update the PR title + description with your comments? I think we'll start auto-generating changelogs soon and that would be helpful. Super excited to see all of this happen 😄 |
@malsf21 You got it chief 👍 |
…te existing tests to match program deletion patterns. Update README.
Superceded by #10 |
This PR turned into a lot more than I anticipated. The gist is that this deploys our backend to a Heroku dyno and prepares it for the backend swap-out. Here's a breakdown of the changes:
Procfile
go.mod
file for our deps.Program
s usestring
s instead oftime.Time
to match the documents currently residing in the database.mostRecentProgram
-aware program deletion indb.HandleDeleteProgram
.db.HandleUpdateProgram
. We now useuid
andpid
query parameters to locate the document to update and verify it belongs to the user. Also, since the frontend only ever updates one document at a time, we can just treat the request body as a partialProgram
object.