This repository was archived by the owner on Nov 14, 2020. It is now read-only.
[Fixes #19] Add Jest #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkasemir
approved these changes
Jan 14, 2019
| @@ -56,9 +55,8 @@ | |||
| "eslint-plugin-jsx-a11y": "^6.0.2", | |||
| "eslint-plugin-react": "^7.4.0", | |||
| "fluent-react": "^0.8.1", | |||
| "istanbul": "^1.0.0-alpha", | |||
| "jest": "^23.6.0", | |||
There was a problem hiding this comment.
so much cleaner, love it.
| </Localized> | ||
| ); | ||
| assert(wrapper.contains(expectedOutput)); | ||
| expect(wrapper).toMatchSnapshot(); |
There was a problem hiding this comment.
👍
I do kind of like the simple expectedOutput as a visual of what this component looks like. The snapshots themselves are hard to read. I think it's a reasonable tradeoff, though, for the thoroughness and simplicity of the test code.
There was a problem hiding this comment.
Yeah, I could go either way here, honestly.
| import { pseudolocalize } from '../src'; | ||
|
|
||
| describe('pseudolocalize', () => { | ||
| it('should transform a message', () => { | ||
| it.only('should transform a message', () => { |
There was a problem hiding this comment.
careful about leaving these in.
Is there a linting rule or similar to prevent accidentally merging this in to master?
There was a problem hiding this comment.
D'oh! :shame:
There is a linting rule. I will find it and add.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: Putting this up to get feedback on the approach before copying it to the
extractionpackage.