Skip to content

ci: test more generously #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: test more generously #742

wants to merge 1 commit into from

Conversation

magistau
Copy link
Contributor

No description provided.

alex-s168
alex-s168 requested changes Jun 22, 2025
View reviewed changes
@magistau magistau requested a review from alex-s168 June 22, 2025 23:13
@magistau
Copy link
Contributor Author

CI failing is due to FFI tests currently being broken (see #741).

@Omnikar Omnikar mentioned this pull request Jun 23, 2025
Closed
alex-s168
alex-s168 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Collaborator

@alex-s168 alex-s168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine

we'll see if it works after merging

@kaikalii
Copy link
Member

CI passes for main. Why not this?

@magistau
Copy link
Contributor Author

CI passes for main. Why not this?

CI on main doesn't run tests in tests_ffi, CI in this PR does, as I mentioned in this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-s168 alex-s168 alex-s168 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magistau @kaikalii @alex-s168