Skip to content

Better linting #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Better linting #779

wants to merge 20 commits into from

Conversation

magistau
Copy link
Contributor

@magistau magistau commented Jul 16, 2025 •
edited
Loading

No description provided.

@magistau magistau force-pushed the clippy branch 4 times, most recently from 0a2ab15 to 8e6a456 Compare July 17, 2025 03:59
@kaikalii
Copy link
Member

I don't really think clippy::pedantic should be used as any sort of standard. It's called "pedantic" for a reason. Some of your changes toward that are unnecessary.

@magistau magistau force-pushed the clippy branch 2 times, most recently from c1f68fc to ed15fa5 Compare July 17, 2025 19:57
@magistau magistau mentioned this pull request Jul 17, 2025
Merged
@magistau magistau force-pushed the clippy branch 2 times, most recently from 19e3d2a to bc295af Compare July 22, 2025 22:53
@magistau magistau force-pushed the clippy branch 3 times, most recently from d5ad383 to 475f554 Compare August 7, 2025 01:56
kaikalii
kaikalii reviewed Aug 7, 2025
View reviewed changes
kaikalii
kaikalii requested changes Aug 7, 2025
View reviewed changes
Copy link
Member

@kaikalii kaikalii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed and found these. Probably a lot more.

parser/src/parse.rs
.push(self.prev_span().sp(ParseError::InvalidArgCount(a.into())));
1
}
let a = if let Ok(a) = a.parse() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this? I like how it was.

@kaikalii
Copy link
Member

kaikalii commented Aug 7, 2025

The relative path in workspace crate .clippy.tomls doesn't seem to work.

❯ cargo clippy
    Checking uiua_parser v0.17.0-dev.2 (C:\Users\Kai\repos\uiua\parser)
error: error reading Clippy's configuration file: invalid key
 --> \\?\C:\Users\Kai\repos\uiua\parser\.clippy.toml:1:1
  |
1 | ../.clippy.toml
  | ^

error: could not compile `uiua_parser` (lib) due to 1 previous error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marcos-cat Marcos-cat Marcos-cat left review comments

@kaikalii kaikalii kaikalii requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magistau @kaikalii @Marcos-cat