feat:临时解决react v18中报错问题方案 #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/398188662/react-code-preview/3jWW3fqsFQpCF2DqKV7jhW86EZyE |
|
@SunLxy 为什么是临时解决。还有什么问题，需要描述清楚。 |
jaywcjlove
reviewed
Apr 22, 2022
src/useCodePreview.ts
Outdated
| str = str.replace('_mount_', `document.getElementById('${playerId.current}')`); | ||
| // react < v18 中写法替换 | ||
| str = str.replace('ReactDOM.render', `ReactDOMClient.createRoot("${playerId.current}").render`); | ||
| // react v18 中写法替换 |
|
@SunLxy 解决测试用例错误。 |
jaywcjlove
added a commit
that referenced
this pull request
Apr 22, 2022
jaywcjlove
reviewed
Apr 22, 2022
| @@ -1,4 +1,6 @@ | |||
| import React, { useEffect, useRef } from 'react'; | |||
| // @ts-ignore | |||
| import ReactDOMClient from 'react-dom/client'; | |||
There was a problem hiding this comment.
不能这样直接引用，如果在 react 17 中引入，import('react-dom') 或者 import('react-dom/client')
使用 try catch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.