Skip to content

Bugfixes/v17/19341 description update models builder generates different types for color picker value #19436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

idseefeld
Copy link
Contributor

Prerequisites

PR #19430 changes the behaviour of the Colour Picker data type. This PR changes the descriptions oft the data type settings accordingly in languages: en, en-US and da

I have decided to propose these changes in a second PR. Thus you can decide independently about the technical and the textual changes.

Description

English (UK):
color-picker-datatype-setting-description

English (US):

colorPickerConfigurations: {
	colorsDescription: 'Add, remove or sort colors', <!-- previous value -->
	colorsDescription: 'Add, remove or sort colors (and labels).',
	colorsTitle: 'Colors',
	showLabelDescription:
		'Stores colors as a JSON object containing both the color hex string and label, rather than just the hex string.', <!-- previous value -->
		'Displays colored field and a label for each color in the color picker, rather than just a colored field.',
},

Danish:

colorPickerConfigurations: {
	colorsTitle: 'Farver',
	colorsDescription: 'Tilføj, fjern eller sorter farver', <!-- previous value -->
	colorsDescription: 'Tilføj, fjern eller sorter farver (og etiketter).',
	showLabelTitle: 'Inkluder label?',
	showLabelDescription:
		'Gemmer farver som et Json-objekt, der både indeholder farvens hex streng og label, i stedet for kun at gemme hex strengen.', <!-- previous value -->
		'Viser et farvet felt og en etiket for hver farve i farvevælgeren i stedet for blot et farvet felt.',
},

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 16:34
Copy link

github-actions bot commented May 27, 2025

Hi there @idseefeld, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Matthew-Wise Matthew-Wise changed the base branch from main to v17/dev May 27, 2025 16:40
@Matthew-Wise Matthew-Wise self-assigned this May 27, 2025
…elsBuilder-generates-different-types-for-Color-Picker-value
@Matthew-Wise Matthew-Wise merged commit 321087c into umbraco:v17/dev May 30, 2025
27 checks passed
@Matthew-Wise
Copy link
Contributor

Thanks for the updating label to reflect your code change @idseefeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants