Add unit test verifying dockerfile aligns with current target framework #19445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new unit test to ensure the Dockerfile’s ASP.NET runtime and SDK versions stay in sync with the project’s current target framework.
- Introduces
DockerFileTestsverifying that the Dockerfile FROM lines match the assembly’s target framework version. - Implements helpers to read the .NET version from both the executing assembly and the Dockerfile.
tests/Umbraco.Tests.UnitTests/Umbraco.Templates/DockerFileTests.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.UnitTests/Umbraco.Templates/DockerFileTests.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.UnitTests/Umbraco.Templates/DockerFileTests.cs
Outdated
Show resolved
Hide resolved
tests/Umbraco.Tests.UnitTests/Umbraco.Templates/DockerFileTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
AndyButland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Added a unit test that checks the
Dockerfiledetails for the .NET version matches with the current target framework, as a check that updating this doesn't get forgotten with each major release.Unit test runs as expected locally, from the build from this PR I can verify that it does the same on the pipeline.
Testing
Visual inspection will suffice.