Skip to content

V16-RC: Login screen cannot load public manifests #19453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release/16.0
Choose a base branch
from

Conversation

iOvergaard
Copy link
Contributor

Description

This fixes two issues:

  1. Public manifests were no longer being loaded on the login screen as outlined in V16.0.0-RC4: Custom login greeting no longer working #19448, so this fixes V16.0.0-RC4: Custom login greeting no longer working #19448
  2. It was not possible to overwrite en-US-specific localizations

Changes

  • Registers required contexts for UmbServerExtensionRegistrator: With V16, it now needs the UmbServerContext
  • Changes the weight of all login localizations, so that you can overwrite them as extensions by default have weight=0
  • Changes the culture of login localizations to match the Backoffice itself, i.e., no country codes: This way you can overwrite Backoffice and Login localizations within one file (this did not work in V15 due to Localization fallback issue #19227 but was fixed already in RC2)

@Copilot Copilot AI review requested due to automatic review settings May 30, 2025 12:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues with the login screen by updating localization configurations and ensuring proper server context registration for public manifests.

  • Updates localization weights, aliases, and cultures to facilitate proper overriding of login localizations.
  • Introduces the required UmbServerContext for the slim backoffice and refines error handling in extension registration.
  • Adjusts server extension registrator methods to disable notifications during manifest retrieval.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

File Description
src/Umbraco.Web.UI.Login/src/localization/manifests.ts Updates localization aliases, names, JS imports, and culture codes to remove country codes and adjust weights.
src/Umbraco.Web.UI.Login/src/localization/lang/en-us.ts Minor formatting and string adjustments for localization content.
src/Umbraco.Web.UI.Login/src/controllers/slim-backoffice-initializer.ts Introduces server context and revises icon registry attachment while improving error logging.
src/Umbraco.Web.UI.Client/src/libs/extension-api/controller/server-extension-registrator.controller.ts Adds disableNotifications option in manifest retrieval methods.

@iOvergaard iOvergaard requested a review from leekelleher May 30, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant