Upgrade array-changes to fix structural moves #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunesimonsen
force-pushed
the
ssimonsen/upgrade-array-changes
branch
from
cd4b9fc to
5bf0333
Compare
papandreou
reviewed
Jul 30, 2025
| @@ -0,0 +1,25 @@ | |||
| const arrayChanges = require('array-changes'); | |||
|
|
|||
| module.exports = function (...args) { | |||
There was a problem hiding this comment.
If we now need to wrap array-changes I guess we could consider making these adjustments directly in the library, or maybe even just copy the whole thing in here. I don't see this as a blocker, just an observation.
There was a problem hiding this comment.
I don't think we should do that, because I think we should consider showing the similar diff with a move. I just don't want to make that change right now.
There was a problem hiding this comment.
Mhh maybe you are right, maybe we don't want to see moves for similar items. Could we merge this, then I'll add an issue to upstream the change into array-changes itself.
sunesimonsen
force-pushed
the
ssimonsen/upgrade-array-changes
branch
from
5bf0333 to
57c21c0
Compare
papandreou
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of array-changes we didn't manage to correctly show structural similar moves, we would just show the actual item being moved.
I opted for just showing a remove and an insert instead of showing a structural diff that is then moved. That simplifies things a bit, but we can always change our minds on this decision.
The plugin failures seems reasonable.