ICU-20575 locale mapping for C.UTF-8 - 64-maint backport #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression was in 1afef30 PR unicode-org#418 [ICU-20187] - We dropped the mapping from "C" in uloc_canonicalize, but then putil did not handle cases where a codepage was set (such as C.UTF-8). - Add an additional check in uprv_getDefaultLocaleID() for locales that end up as "C" or "POSIX" after removing codepage suffix. - Also fix regression where aa@bb would become aa__BB__BB (incorrectly doubled __BB) (cherry picked from commit 075cefb)
srl295
added
the
cherry-pick
|
this PR says it goes into master -- should it not go into maint/maint-64 ? |
|
@srl295 I changed the branch on this PR to go into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression was in 1afef30
PR #418 ICU-20187
We dropped the mapping from "C" in
uloc_canonicalize,but then putil.cpp did not handle cases where a codepage was
set (such as "C.UTF-8").
Add an additional check in
uprv_getDefaultLocaleID()forlocales that end up as "C" or "POSIX" after removing codepage
suffix.
Also fix regression where aa@bb would become aa__BB__BB
(incorrectly doubled __BB)
(cherry picked from commit 075cefb and #634 )
Checklist