Skip to content

Allow valid message invalidation with new default functions #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

aphillips
Copy link
Member

@aphillips aphillips commented Feb 20, 2025

Fixes (part of) #1024. #1033

@macchiati Demonstrated that the stability policy could logically conflict with locally-assigned default-namespace functions or options. This fixes the policy to allow us to assign new values that conflict with such.

I believe the change is consistent with working group consensus.

Fixes (part of) #1024.

@macchiati Demonstrated that the stability policy could logically conflict with locally-assigned default-namespace functions or options. This fixes the policy to allow us to assign **_new_** values that conflict with such.
@aphillips aphillips added normative Issue affects normative text in the specification specification Issue affects the specification LDML47 LDML 47 Release (Stable) labels Feb 20, 2025
@macchiati
Copy link
Member

I retired the issue that had multiple sub-issues, so the description should reference #1033

@aphillips aphillips requested a review from macchiati February 20, 2025 23:55
@aphillips
Copy link
Member Author

I merged my suggestion (you can uncollapse @macchiati's comment to see the discussion). Please comment if you want the note back or some other wording.

@macchiati
Copy link
Member

The change is good, but just to note that it doesn't address #1033

Co-authored-by: Eemeli Aro <[email protected]>
@aphillips
Copy link
Member Author

aphillips commented Feb 21, 2025

I merged @eemeli's text. I think that's an improvement. If we needed to, we could add a note calling out that a valid message can start to have errors if users or implementers have abused a reserved identifier--that should go in the stability policy section about identifiers.

With that change, I'm removing the normative tag, since it nearly reverts the sentence to its original form, only replacing the vague term "invalid" with the formal term "not valid".

@aphillips aphillips requested a review from eemeli February 21, 2025 16:58
@aphillips aphillips added editorial Issue is non-normative and removed normative Issue affects normative text in the specification labels Feb 21, 2025
Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important for us to have a term like the current valid that a messsage can be verified to pass with no reference to anything outside the message, including functions.

I would not be opposed to defining a name for a message that we know is going to produce an error during formatting because it has operand or option values that don't pass muster, but I'd also like to note that that check is in most cases not going to prove that the message will not produce an error, because formatting relies on external values that are not necessarily known ahead of time.

@aphillips
Copy link
Member Author

Merging this. Other changes to follow for the name collision parts of #1033

@aphillips aphillips merged commit 3c82b43 into main Feb 21, 2025
1 check passed
@aphillips aphillips deleted the aphillips-stability-policy-fix branch February 21, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Issue is non-normative LDML47 LDML 47 Release (Stable) specification Issue affects the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants