Skip to content

Use curly braces to delimit patterns #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2022
Merged

Use curly braces to delimit patterns #288

merged 2 commits into from
Jul 11, 2022

Conversation

stasm
Copy link
Collaborator

@stasm stasm commented Jun 28, 2022

Closes #255.

eemeli
eemeli approved these changes Jun 29, 2022
View reviewed changes
Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an additional observation, dropping [ simplifies a potential "plain vs. messageformat" detector as well, as it now only needs to look for a { character.

@stasm @eemeli
Reword "nested" to "inner"
6216d0e 
Make it clearer that there's no deep nesting possible.

Co-authored-by: Eemeli Aro <[email protected]>
mihnita
mihnita approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@romulocintra romulocintra merged commit d430e27 into unicode-org:develop Jul 11, 2022
echeran pushed a commit that referenced this pull request Sep 20, 2022
@stasm @eemeli @echeran
Use curly braces to delimit patterns (#288)
c2f8efe 
* Use curly braces to delimit patterns

Closes #255.

* Reword "nested" to "inner"

Make it clearer that there's no deep nesting possible.

Co-authored-by: Eemeli Aro <[email protected]>

Co-authored-by: Eemeli Aro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

@echeran echeran echeran approved these changes

@mihnita mihnita mihnita approved these changes

@aphillips aphillips Awaiting requested review from aphillips

@zbraniecki zbraniecki Awaiting requested review from zbraniecki

@romulocintra romulocintra Awaiting requested review from romulocintra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stasm @eemeli @echeran @mihnita @romulocintra