Skip to content

Forbid empty placeholders in the syntax #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

Forbid empty placeholders in the syntax #348

merged 1 commit into from
Feb 27, 2023

Conversation

stasm
Copy link
Collaborator

@stasm stasm commented Feb 14, 2023 •
edited
Loading

  • There isn't an evident use-case for empty placeholders at this time.
  • Empty placeholders are invalid in ICU MF1.
  • Forbidding them will make it a bit easier to specify the precise rules of whitespace.
  • The EBNF snippet in syntax.md actually requires that placeholders be non-empty. I don't know at which point syntax.md and message.ebnf diverged.

Fixes #345.

@stasm
Forbid empty placeholders in the syntax
6d09a8f 
* There isn't an evident use-case for empty placeholders at this time.
* Empty placeholders are invalid in ICU MF1.
* Forbidding them will make it a bit easier to specify the precise rules of whitespace.
@stasm stasm merged commit 83b81dd into main Feb 27, 2023
@stasm stasm deleted the sta/forbid-empty-placeholders branch February 27, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphillips aphillips aphillips approved these changes

@eemeli eemeli eemeli approved these changes

@mihnita mihnita mihnita approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow empty placeholders in the syntax
4 participants
@stasm @aphillips @eemeli @mihnita