Skip to content

Allow expressions without annotations to dynamically choose a function #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Sep 4, 2023

Conversation

aphillips
Copy link
Member

Fixes #42

Also addresses some problems with normative terms in the same text.

Fixes #42 

Also addresses some problems with normative terms in the same text.
@aphillips aphillips added Agenda+ Requested for upcoming teleconference formatting Issue pertains to the formatting section of the spec labels Aug 19, 2023
@aphillips aphillips requested a review from eemeli August 21, 2023 14:41
Co-authored-by: Eemeli Aro <[email protected]>
@macchiati
Copy link
Member

macchiati commented Aug 28, 2023 via email

@aphillips
Copy link
Member Author

@macchiati We discussed this in teleconference today. Implementations will be allowed to choose how to process values based on type without having a specific annotation, so that level of compatibility will be present.

- Made one fix to inappropriate normative language

- Removed the formatting allowance previously inserted
- Reversed the order of the expression resolution "sieve", so that the complicated optional goo goes at the end.
- Allow (but not require) an implementation to use the value of a _variable_ to assign the annotation
- Allow (but not require) an implementation to use the value of a _literal_ to assign the annotation if-and-only-if the literal does not appear in an declaration

This is complicated and probably begging for examples.
@aphillips aphillips requested review from eemeli and mihnita August 29, 2023 16:26
@aphillips
Copy link
Member Author

Here is the first cut at adopting the consensus from the 2023-08-28 call. I suspect that examples are needed. In particular, while the normative text allows implementations to make the kind of inference we're talking about here, it might not be clear to readers.

Let's make the normative gunk first, although I welcome suggestions for how to make this clear. I'm going to toy with some examples.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a merge from main to fix the Prettier action. A small bunch of stylistic fixes inline; otherwise this starts to look like an improvement on what we've currently got.

Co-authored-by: Eemeli Aro <[email protected]>
aphillips and others added 4 commits August 31, 2023 11:17
@aphillips aphillips merged commit fcf1a82 into main Sep 4, 2023
@aphillips aphillips deleted the aphillips-allow-defaulting-of-functions branch September 4, 2023 17:28
Copy link
Collaborator

@stasm stasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching up with the developments of the past two weeks. LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+ Requested for upcoming teleconference formatting Issue pertains to the formatting section of the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic selection of formatter by argument type
5 participants