Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #472 was merged, it ended up including changes suggested by @aphillips in #472 (comment) that had not been fully reviewed. This PR is about fixing issues related to that late addition.
Right now this is mostly editorial, and re-introducing a phrase that was dropped on merge:
However, we should also decide here what to do about this indented note that was included in the change:
For this to be valid, we need to find a way to make it play nice with this other bit of policy:
In other words, we need to come up with a syntax that allows for space for keywords to be reserved, so that a current parser won't syntax-error with them. At least thus far, each of our keywords associates with one of more subsequent expressions or patterns.
This is problematic with a syntax like our current one, which uses
{
at the top level as both an expression and pattern start, depending on the context. Essentially, it's not possible to determine ifkeyword {foo|bar}
is valid without knowing if it's meant to be processed as an expression or a pattern.With a syntax as proposed in this alternative, this problem becomes at least tractable.
This note should not be left as is; either it needs to be dropped, or it needs to be made explicitly normative.