Skip to content

Add missing hourCycle to :datetime timeStyle/dateStyle <formatSignature> #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Jan 15, 2024

As discussed in #570 (comment), the hourCycle option is also valid when using the timeStyle or dateStyle options of :datetime.

I suggest this is considered as an editorial change and fast-tracked.

@eemeli eemeli added functions Issue pertains to the default function set fast-track Editorial change permitted to use fast-track merge rules editorial Issue is non-normative labels Jan 15, 2024
@aphillips
Copy link
Member

Why not stuff this into #570? Also, we should probably fix the upstream decisions about the default registry.

@eemeli
Copy link
Collaborator Author

eemeli commented Jan 15, 2024

Because they're separate changes, and I wasn't sure if we had consensus on adding :date and :time.

@aphillips
Copy link
Member

We don't have consensus on :date and :time. Let's see if we can get there in the call?

@aphillips aphillips merged commit c3ee018 into main Jan 15, 2024
@aphillips aphillips deleted the hour-cycle branch January 15, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Issue is non-normative fast-track Editorial change permitted to use fast-track merge rules functions Issue pertains to the default function set
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants