-
-
Notifications
You must be signed in to change notification settings - Fork 36
Add hour12 date/time override option #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looking at the whole file, it looks like the way "Date/time override options" is added to
Which is kind of hard to discover.
But it should not have it at all. |
This meets fast-track requirements and was approved in the 2024-11-18 call previously. |
Allowing The fix for that would be simple: remove it from I can live with the option "hidden in text" for |
@@ -995,6 +992,7 @@ The function `:date` has these _options_: | |||
- `long` | |||
- `medium` (default) | |||
- `short` | |||
- _Date/time override options_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line.
The overrides right now only support hour12
, which is not valid on dates.
This is the part of the changes originally proposed in #911 that was deemed as immediately mergeable on today's call.
Perhaps a little pre-emptively, it adopts the nomenclature to be introduced in #946.
This PR is expected to be followed up with separate PRs for the RECOMMENDED override options.