-
-
Notifications
You must be signed in to change notification settings - Fork 36
Add calendar and numberingSystem options to date/time #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I resolved the conflict. In doing so, I reordered the proposed options below the REQUIRED one and rephrased the text slightly to take advantage of the fact that REQUIRED and RECOMMENDED are 2119 keywords. Please have a look. |
LGTM. Shall I go ahead and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending the inline suggestion to drop the maturity level mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least the calendar
and numberingSystem
mentions should also be removed from this note:
message-format-wg/spec/registry.md
Lines 952 to 964 in 960f800
> [!NOTE] | |
> The following options do not have default values because they are only to be used | |
> as overrides for locale-and-value dependent implementation-defined defaults. | |
The following date/time options are **not** part of the default registry. | |
Implementations SHOULD avoid creating options that conflict with these, but | |
are encouraged to track development of these options during Tech Preview: | |
- `calendar` (default is locale-specific) | |
- valid [Unicode Calendar Identifier](https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#UnicodeCalendarIdentifier) | |
- `numberingSystem` (default is locale-specific) | |
- valid [Unicode Number System Identifier](https://cldr-smoke.unicode.org/spec/main/ldml/tr35.html#UnicodeNumberSystemIdentifier) | |
- `timeZone` (default is system default time zone or UTC) | |
- valid identifier per [BCP175](https://www.rfc-editor.org/rfc/rfc6557) |
@eemeli I will make a separate PR to remove the note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with removing the note separately.
Co-authored-by: Eemeli Aro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I can review, but can't approve.
My only button is "Submit review"
So: approved
This is as per the discussion in the WG, separating them out from #911
Two changes from that: