Make GenerateConfusables generate NFKD instead of NFKC #1205
Conversation
Also fix a typo in the name of the method This fixes unicode-org/properties#459
roozbehp
requested review from
eggrobin,
josh-hadley,
macchiati and
markusicu
|
This is ready for review so please take a look. (I didn't |
|
I'll look at it next week. (I'd replied to a github email, but that seems to have bounced.) |
|
@macchiati: We verified that some of the output changes are correct/desirable, such as the change from caron to breve for U+01C6. Mark please review. |
|
Ping @macchiati |
|
@roozbehp FYI -- I rephrased the PR description from simple "This fixes (issue)" to prevent GitHub from auto-closing the issue. |
unicodetools/src/main/java/org/unicode/text/UCD/GenerateConfusables.java
Outdated
Show resolved
Hide resolved
|
PTAL. |
|
@eggrobin Why does GitHub think I'm changing the repertoire?! |
| private static Normalizer INSTANCE; | ||
| static String normalize(String cf) { | ||
| if (INSTANCE == null) { | ||
| INSTANCE = new Normalizer(UCD_Types.NFKD, Default.ucdVersion()); | ||
| INSTANCE.setSpacingSubstitute(); | ||
| } |
There was a problem hiding this comment.
It should work to have the constructor unconditionally create the instance...
I probably misled you with suggesting normalize() as a static method.
Anyway, nicer than before, and we can revisit later.
Also fix a typo in the name of the method
This fixes problems described in the following issue.
Rephrased from simple "This fixes (issue)" to prevent GitHub from auto-closing the issue.