add kubeflow to flyte migration guide #370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying docs with
|
| Latest commit: |
f5a541a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4091b8fc.docs-dog.pages.dev |
| Branch Preview URL: | https://jan-add-kubeflow-migration-g.docs-dog.pages.dev |
nelsonjr
requested changes
Jun 5, 2025
| @@ -0,0 +1,112 @@ | |||
| from flytekit import workflow, task, FlyteDirectory, ImageSpec, FlyteFile, Resources | |||
There was a problem hiding this comment.
The best place to put runnable code is in unionai-examples repo.
| - By leveraging **FlyteDirectories**, we reduced the number of tasks from two to one — simplifying the overall structure. | ||
| - …and much more! | ||
|
|
||
| {{< download "/docs/flyte/code/example_flyte_workflow.py" "example_flyte_workflow.py" >}} |
There was a problem hiding this comment.
Do not hardcode absolute paths or move them to /content/_static/ and refer as /_static/... like here: https://github.com/unionai/docs/blob/d04fde5fda8a6d24dba1878aea839cffc261e819/content/deployment/single-sign-on-setup/google-oidc.md?plain=1#L43
Instead, I suggest making the examples actual tutorial examples, like this one: https://github.com/unionai/docs/blob/main/content/tutorials/finance/credit-default-xgboost.md?plain=1.
You document the code and add them as markdown in this repository.
There was a problem hiding this comment.
@ppiegaze FYI and for guidance for Jan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add kubeflow migration guide.