This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Move route specific keyboardshortcuts to pages #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that when we are on the Catalog say, we don't trigger Workspace keyboardshortcuts. Notably this also means that things like the Finder are no longer an App concern, by a Workspace shortcut. There's a few other things that should be moved down a layer like toggling the sidebar, but this should only happen for Share and not for Local (this is not tackled in this effort).
pchiusano
approved these changes
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't want Workspace keyboard shortcuts to trigger when on another page like the Catalog.
Solution
Only pass submessages down to sub pages if the corresponding route is active.
Notably this also means that things like the Finder are no longer an App concern, by a Workspace shortcut. There's a few other things that should be moved down a layer like toggling the sidebar, but this should only happen for Share and not for Local (this is not tackled in this effort).
Caveats/Notes
Issues that address things you didn't get to or general notes