This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Use normal hrefs for the App title click #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojberg
force-pushed
the
use-urls-for-app-title-click
branch
from
f2a1b56 to
aa12a61
Compare
When clicking the title of the app ("Unison Share" / "Unison Local"),
simply use a `Click.Href` of `"/"` to navigate to the root page of the
application instead of a complicated perspective change.
hojberg
force-pushed
the
use-urls-for-app-title-click
branch
from
aa12a61 to
695e642
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When click the app title on pages like the catalog or the user page, the url isn't changed appropriately
Solution
When clicking the title of the app ("Unison Share" / "Unison Local"), simply use a
Click.Hrefof"/"to navigate to the root page of the application instead of a complicated perspective change.