Path segments can be named ()
#1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
approved these changes
May 30, 2020
There was a problem hiding this comment.
Bleh, thanks.
For background, these were illegal identifiers that were inserted out of band, and now we couldn't get rid of them. We'll want to revisit this, once we can escape identifiers (#1589). /cc @mitchellwrosen
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for path segments to be named
(). The main purpose of this change is to be able to delete the empty namespace.base.()which currently exists in Base.Implementation notes
Adds a special case to the path parser. If the segment is neither a symboly or wordy identifier, we check if it's literally "()".
Depends on #1591
Test coverage
There is a transcript provided.