Skip to content

Add -rtsopts to unison ghc-options #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Conversation

mitchellwrosen
Copy link
Member

This PR just adds -rtsopts to the unison executable, so a greater number of runtime knobs can be tweaked with command-line options

@aryairani
Copy link
Contributor

We'll have to do this again after #1603. Also do you know if and how it affects build times?

@aryairani
Copy link
Contributor

Also I think stack build --profile does this, along with building the libraries with the right settings? or am I mixed up?

@mitchellwrosen
Copy link
Member Author

It doesn't affect build times, it's just whether the resulting executable allows to to tweak things (honestly, I'm not really sure why you wouldn't want to set this 🤷)

About stack build --profile - I'm not sure if that sets -rtsopts too; at least in GHC they're distinct (-rtsopts and -prof)

@aryairani
Copy link
Contributor

aryairani commented Jun 8, 2020

If -rtsopts is required to be able to supply +RTS ... options to the built executable's command line, then --profile definitely enables at least that; if it isn't, then I dunno.

@mitchellwrosen
Copy link
Member Author

mitchellwrosen commented Jun 8, 2020

Not all +RTS opts are disabled without -rtsopts, only "most" according to GHC. -s (print stats) and -p (profile? or something?) both seem to work, but things like tweaking the nursery size (-A) do not

@mitchellwrosen mitchellwrosen merged commit 8b57038 into master Jun 8, 2020
@mitchellwrosen mitchellwrosen deleted the mitchell/rtsopts branch June 8, 2020 21:16
@pchiusano pchiusano mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants