Highlight below the fold as a comment #1680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `uBelowFold` syntax region, highlighted as a comment.
Unison uses a comment like this to signal the fold after an `edit`
---- Anything below this line is ignored by Unison.
The previous definition of `uBelowFold` was a line starting with
"---- ". But in fact a fold is triggered by 3 or more dashes at the
start of a line, and doesn't require a space.
|
@osfameron cool! would you mind adding yourself to CONTRIBUTORS.markdown as part of this PR? |
|
OK, updated Contributors.markdown above! |
pchiusano
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
uBelowFoldsyntax region, highlighted as a comment.Overview
As Unison itself ignores everything below the fold, it makes sense to format the contents as a comment, rather than Unison highlighted.
Implementation notes
This uses the Syntax Region highlighting feature in Vim.
I'm not 100% how the
skipandendfeatures work, but I copied it fromperl.vimas Perl has an analogous__END__marker construct.Interesting/controversial decisions
Don't think so.
Test coverage
None provided, I don't know how to test Vim syntax files.
Loose ends
Could potentially add folding support?