Implement STM builtins #1787
Merged
Implement STM builtins #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Not working as of yet
pchiusano
approved these changes
Jan 15, 2021
pchiusano
added
the
ready-to-merge
pchiusano
reviewed
Jan 15, 2021
| @@ -1228,13 +1253,15 @@ builtinLookup | |||
|
|
|||
| , ("jumpCont", jumpk) | |||
|
|
|||
| , ("IO.forkComp", fork'comp) | |||
| , ("IO.forkComp.v2", fork'comp) | |||
There was a problem hiding this comment.
@stew FYI, not sure if you were also hitting this.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds
STMandTVarstuff to the new runtime. The implementation is a pretty direct wrapping of GHC's API, and was more or less straight forward. Most operations are 'foreign' functions calling the GHC analogue while coercing theSTMintoIOif applicable.atomicallyis the only new primop, and is implemented by evaluating a closure with a temporary stack inside GHC'satomicallyimplementation. This usesunsafeIOToSTMto do all the runtime operations necessary, but this should not be a problem as long as the unison code is well typed, because the only mutable state is local to the transaction.There is a test transcript that should use all the operations currently implemented. I didn't try very hard to trigger transaction issues, but I think the implementation is sound.