Skip to content

Fix boolean pattern compilation in the new runtime #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Conversation

dolio
Copy link
Contributor

@dolio dolio commented Feb 10, 2021

The case for handling boolean patterns was just missing in the pattern compiler. It has been added.

I also added some more pattern matching tests.

Fixes #1711

@pchiusano
Copy link
Member

@dolio
Copy link
Contributor Author

dolio commented Feb 10, 2021

I'm not actually sure why it doesn't pass. The tests work on my machine.

@dolio
Copy link
Contributor Author

dolio commented Feb 10, 2021

Oh, I know what the problem is. The tests are pinned to a broken version of containers that causes ill-formed maps (IntMap I think) to be built sometimes. It's not broken for me locally because I use a newer version. The bug has been fixed for months, but stackage still has the broken version pinned.

Should I just remove the part of the test that fails?

@pchiusano
Copy link
Member

@dolio you can locally override which version of containers gets used by Stack I think in the stack.yaml? Or I'm not sure. But that's the correct thing to do, since at the moment stack is the official way we do builds and produce releases, so we want that to also use the correct version of containers.

Copy link
Member

@pchiusano pchiusano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pchiusano pchiusano merged commit a11cd47 into trunk Feb 11, 2021
@pchiusano pchiusano deleted the fix/1711 branch February 11, 2021 20:45
@pchiusano pchiusano mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New runtime fails with "Blank" when evaluating this watch expression
2 participants