Skip to content

Explicitly list 4 build conditions for the mergify bot #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

aryairani
Copy link
Contributor

Hopefully fixes #1861.

Hopefully fixes #1861
@aryairani aryairani added the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Apr 8, 2021
@aryairani
Copy link
Contributor Author

aryairani commented Apr 8, 2021

It might need to have (pull_request) added to each one, to match the action names. We probably don't care about the (push) ones, right?

@pchiusano pchiusano merged commit 5c65d3b into trunk Apr 8, 2021
@pchiusano pchiusano deleted the mergify-github-actions branch April 8, 2021 16:41
@mergify mergify bot removed the ready-to-merge Apply this to a PR and it will get merged automatically once CI passes and 1 reviewer has approved label Apr 8, 2021
@aryairani
Copy link
Contributor Author

aryairani commented Apr 10, 2021

Hmm... we were expecting it to merge automatically, right, but it didn't? Not sure how much time it takes to notice the review approval.

@pchiusano pchiusano mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ready-to-merge Github Label no longer readies to merge?
2 participants